Skip to content

check: a card that shares one word with a line isn't held to it as a caption - #102

Merged
shinyobjectz merged 2 commits into
shinyobjectz:mainfrom
SirSicard:check-cues
Nov 12, 2026
Merged

shinyobjectz merged 2 commits into
shinyobjectz:mainfrom
SirSicard:check-cues

Conversation

@SirSicard

@SirSicard SirSicard commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Requested by Mattias

Part of #89 (item 3).

The cue rule anchored a card on any one word of weight said within 2 s. A card sharing a single word with an unrelated spoken line ("Wirestock x OpenAI Sora" against "At Wirestock, I worked on...") was therefore held to that word's time.

What changes (apps/check/src/text.rs, cues)

  • A text counts as a caption only when at least half its words match the spoken run in order.
  • A one-word card matches only within ±0.75 s of its word.
  • Words are compared by the shared word_key, the norm the rule already uses since DR28.
  • A caption is still timed from its first word. a_caption_is_timed_from_the_first_word_it_shows passes, and "Build the future" is still flagged, as you described.
  • New test a_card_sharing_one_word_with_another_line_isnt_held_to_it: it covers the two false errors from our film, the one-word case, and a real caption still found.

cargo test -p raea-app-check passes.

Also merged onto main 0ea4eab on its own: cargo test -p raea-app-check passes (28, 0 failed), a_caption_is_timed_from_the_first_word_it_shows included.

This and the check-safe-area PR each add a test at the end of apps/check/src/tests.rs, so whichever merges second has a one-hunk conflict there (keep both tests).


🤖 Generated with Claude Code

…as a caption

The cue rule anchored on any one word of weight within 2 s, so a card
sharing a single word with another line ("Wirestock x OpenAI Sora" against
"At Wirestock, I worked on...") was held to that word's time. A text now
counts as a caption only when at least half its words match the spoken run
in order, and a one-word card only within 0.75 s of its word. Words are
compared by the shared word_key, as the rest of the rule does. A caption is
still timed from its first word, so a card whose first word was said earlier
is still flagged, by design.

Part of shinyobjectz#89

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@shinyobjectz
shinyobjectz merged commit e90d70f into shinyobjectz:main Nov 12, 2026
4 checks passed
@shinyobjectz

Copy link
Copy Markdown
Owner

Merged, thanks. I merged main into the branch first (the flashing screen had moved to its own crate to make room in apps/check); your commit is unchanged and CI passed on the result. It'll ship in 0.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants