Repository navigation
check: a card that shares one word with a line isn't held to it as a caption - #102
Merged
Merged
Conversation
…as a caption
The cue rule anchored on any one word of weight within 2 s, so a card
sharing a single word with another line ("Wirestock x OpenAI Sora" against
"At Wirestock, I worked on...") was held to that word's time. A text now
counts as a caption only when at least half its words match the spoken run
in order, and a one-word card only within 0.75 s of its word. Words are
compared by the shared word_key, as the rest of the rule does. A caption is
still timed from its first word, so a card whose first word was said earlier
is still flagged, by design.
Part of shinyobjectz#89
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Merged, thanks. I merged main into the branch first (the flashing screen had moved to its own crate to make room in apps/check); your commit is unchanged and CI passed on the result. It'll ship in 0.1.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Mattias
Part of #89 (item 3).
The cue rule anchored a card on any one word of weight said within 2 s. A card sharing a single word with an unrelated spoken line ("Wirestock x OpenAI Sora" against "At Wirestock, I worked on...") was therefore held to that word's time.
What changes (
apps/check/src/text.rs,cues)word_key, thenormthe rule already uses since DR28.a_caption_is_timed_from_the_first_word_it_showspasses, and "Build the future" is still flagged, as you described.a_card_sharing_one_word_with_another_line_isnt_held_to_it: it covers the two false errors from our film, the one-word case, and a real caption still found.cargo test -p raea-app-checkpasses.Also merged onto main 0ea4eab on its own:
cargo test -p raea-app-checkpasses (28, 0 failed),a_caption_is_timed_from_the_first_word_it_showsincluded.This and the check-safe-area PR each add a test at the end of
apps/check/src/tests.rs, so whichever merges second has a one-hunk conflict there (keep both tests).🤖 Generated with Claude Code